Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default enable HIBP check #148

Closed
wants to merge 3 commits into from
Closed

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 12, 2021

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added this to the Nextcloud 22 milestone Apr 12, 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke
Copy link
Member

@LukasReschke 🏓

@LukasReschke
Copy link
Member

I think we can do this but we should also check for has_internet_connection here:

try {
$response = $client->get(
'https://api.pwnedpasswords.com/range/' . $range,
[
'timeout' => 5,
'headers' => [
'Add-Padding' => 'true'
]
]
);
} catch (\Exception $e) {
$this->logger->logException($e, ['level' => ILogger::INFO]);
return;
}

@LukasReschke LukasReschke self-assigned this May 25, 2021
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke
Copy link
Member

Actually I moved this a directly into the config check, this also makes it more obvious for admins in the UI that somehow HIBP is not enabled :)

c735836

@MorrisJobke 🏓

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable for 22

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

Okay - this is somehow merged into master but not marked in this PR: f356c91

@LukasReschke LukasReschke deleted the enh/default_hipb_check branch May 25, 2021 15:19
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants