Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump @nextcloud/vue to v8-beta.7 #1676

Merged
merged 3 commits into from
Sep 29, 2023
Merged

chore: Bump @nextcloud/vue to v8-beta.7 #1676

merged 3 commits into from
Sep 29, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 29, 2023

  • Upgrade v7 → v8-beta
  • Adapt to breaking changes
  • Smoke test

@Pytal Pytal added this to the Nextcloud 28 milestone Sep 29, 2023
@Pytal Pytal requested a review from Antreesy September 29, 2023 00:04
@Pytal Pytal self-assigned this Sep 29, 2023
@Pytal Pytal mentioned this pull request Sep 29, 2023
Closed
12 tasks
nickvergessen and others added 3 commits September 29, 2023 09:02
@nickvergessen
chore: Bump @nextcloud/vue to v8-beta.7
5874641 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@Pytal @nickvergessen
chore: Adapt to breaking @nextcloud/vue v8 changes
51077ab 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @nickvergessen
chore: compile assets
fca0f20 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@nickvergessen
Copy link
Member

Thanks, I cleaned up the package-locked.json by replacing your commit with:

npm remove @nextcloud/vue
npm i -S @nextcloud/vue@^8.0.0-beta.7

That updated some more depedencies:

-/*! @license DOMPurify 2.4.7 | (c) Cure53 and other contributors | Released under the Apache license 2.0 and Mozilla Public License 2.0 | github.com/cure53/DOMPurify/blob/2.4.7/LICENSE */
+/*! @license DOMPurify 3.0.6 | (c) Cure53 and other contributors | Released under the Apache license 2.0 and Mozilla Public License 2.0 | github.com/cure53/DOMPurify/blob/3.0.6/LICENSE */

…

-* focus-trap 7.5.2
+* focus-trap 7.5.3

Antreesy
Antreesy approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, also checked changes for used components stable7 / master
Looks good, thanks!

@Pytal Pytal merged commit c639fe0 into master Sep 29, 2023
19 checks passed
@Pytal Pytal deleted the deps/nextcloud/vue-8.0.0-beta.7 branch September 29, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@Pytal Pytal

Labels
4. to release
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @nickvergessen @Antreesy