Allow http-only host.docker.internal as push proxy #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
fix/push-proxy-allow-http-docker-internal-host
branch
from
cc5cbc8 to
f62e554
Compare
|
I wonder why you need this as the software you need to run there is not available as docker not in general 🤔 |
|
This is for development purposes (just like using localhost). The Nextcloud instance runs in docker, but the push proxy runs on the machine itself. |
|
Ah sorry I didn't understand your comment correctly. I developed my own push proxy :D |
Oh, okay |
nickvergessen
requested changes
Jul 21, 2022
provokateurin
force-pushed
the
fix/push-proxy-allow-http-docker-internal-host
branch
from
f62e554 to
74f1472
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/push-proxy-allow-http-docker-internal-host
branch
from
74f1472 to
e371ca9
Compare
nickvergessen
approved these changes
Jul 21, 2022
|
I guess this will be released along the next Nextcloud release? |
|
Yeah, the app is shipped. So will come with 25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the hostname commonly used (default by docker desktop, usually also used on linux) for accessing the host machine.
Fixes nextcloud/neon#30