feat(cli): Allow to replace and delete CLI notifications #457
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors | |
| # SPDX-License-Identifier: MIT | |
| name: Performance | |
| on: | |
| pull_request: | |
| paths: | |
| - '.github/workflows/**' | |
| - 'appinfo/**' | |
| - 'lib/**' | |
| - 'templates/**' | |
| - 'tests/**' | |
| - 'vendor/**' | |
| - 'vendor-bin/**' | |
| - '.php-cs-fixer.dist.php' | |
| - 'composer.json' | |
| - 'composer.lock' | |
| permissions: | |
| contents: read | |
| pull-requests: write | |
| concurrency: | |
| group: performance-sqlite-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| jobs: | |
| matrix: | |
| runs-on: ubuntu-latest-low | |
| outputs: | |
| php-available: ${{ steps.versions.outputs.php-available-list }} | |
| server-max: ${{ steps.versions.outputs.branches-max-list }} | |
| steps: | |
| - name: Checkout app | |
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |
| - name: Get version matrix | |
| id: versions | |
| uses: icewind1991/nextcloud-version-matrix@7d433286e92318f51ed0537b6c77374759e12f46 # v1.3.0 | |
| changes: | |
| runs-on: ubuntu-latest-low | |
| outputs: | |
| src: ${{ steps.changes.outputs.src}} | |
| steps: | |
| - uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0 | |
| id: changes | |
| continue-on-error: true | |
| with: | |
| filters: | | |
| src: | |
| - '.github/workflows/**' | |
| - 'appinfo/**' | |
| - 'lib/**' | |
| - 'templates/**' | |
| - 'tests/**' | |
| - 'vendor/**' | |
| - 'vendor-bin/**' | |
| - '.php-cs-fixer.dist.php' | |
| - 'composer.json' | |
| - 'composer.lock' | |
| performance-sqlite: | |
| runs-on: ubuntu-latest | |
| needs: [changes, matrix] | |
| if: needs.changes.outputs.src != 'false' | |
| strategy: | |
| matrix: | |
| php-versions: ${{ fromJson(needs.matrix.outputs.php-available) }} | |
| server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }} | |
| steps: | |
| - name: Set app env | |
| run: | | |
| # Split and keep last | |
| echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV | |
| - name: Checkout server | |
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |
| with: | |
| submodules: true | |
| repository: nextcloud/server | |
| ref: ${{ matrix.server-versions }} | |
| - name: Checkout app | |
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |
| with: | |
| path: apps/${{ env.APP_NAME }} | |
| - name: Set up php ${{ matrix.php-versions }} | |
| uses: shivammathur/setup-php@6d7209f44a25a59e904b1ee9f3b0c33ab2cd888d # v2 | |
| with: | |
| php-version: ${{ matrix.php-versions }} | |
| # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation | |
| extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite | |
| coverage: none | |
| ini-file: development | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Check composer file existence | |
| id: check_composer | |
| uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2 | |
| with: | |
| files: apps/${{ env.APP_NAME }}/composer.json | |
| - name: Set up dependencies | |
| # Only run if phpunit config file exists | |
| if: steps.check_composer.outputs.files_exists == 'true' | |
| working-directory: apps/${{ env.APP_NAME }} | |
| run: composer i | |
| - name: Set up Nextcloud | |
| env: | |
| DB_PORT: 4444 | |
| run: | | |
| mkdir data | |
| ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass admin | |
| ./occ app:enable --force ${{ env.APP_NAME }} | |
| ./occ config:system:set query_log_file --value "$PWD/query.log" | |
| # - name: Check PHPUnit script is defined | |
| # id: check_phpunit | |
| # continue-on-error: true | |
| # working-directory: apps/${{ env.APP_NAME }} | |
| # run: | | |
| # composer run --list | grep "^ test:unit " | wc -l | grep 1 | |
| # | |
| # - name: PHPUnit | |
| # # Only run if phpunit config file exists | |
| # if: steps.check_phpunit.outcome == 'success' | |
| # working-directory: apps/${{ env.APP_NAME }} | |
| # run: composer run test:unit | |
| - name: Check PHPUnit integration script is defined | |
| id: check_integration | |
| continue-on-error: true | |
| working-directory: apps/${{ env.APP_NAME }} | |
| run: | | |
| composer run --list | grep "^ test:integration " | wc -l | grep 1 | |
| - name: Run Nextcloud | |
| # Only run if phpunit integration config file exists | |
| if: steps.check_integration.outcome == 'success' | |
| run: php -S localhost:8080 & | |
| - name: PHPUnit integration | |
| # Only run if phpunit integration config file exists | |
| if: steps.check_integration.outcome == 'success' | |
| working-directory: apps/${{ env.APP_NAME }} | |
| run: composer run test:integration | |
| - name: Print query.log | |
| run: cat query.log | |
| - name: Query count | |
| uses: actions/github-script@v5 | |
| with: | |
| github-token: ${{secrets.GITHUB_TOKEN}} | |
| script: | | |
| let myOutput = '' | |
| let myError = '' | |
| const options = {} | |
| options.listeners = { | |
| stdout: (data) => { | |
| myOutput += data.toString() | |
| }, | |
| stderr: (data) => { | |
| myError += data.toString() | |
| } | |
| } | |
| await exec.exec(`/bin/bash -c "cat query.log | egrep '(DELETE|UPDATE|INSERT|SELECT)' | awk 'sub(/^[^DISU]*/, \\"\\")' | wc -l"`, [], options) | |
| msg = myOutput | |
| const queryCount = parseInt(myOutput, 10) | |
| myOutput = '' | |
| await exec.exec('cat', ['apps/notifications/tests/Integration/base-query-count.txt'], options) | |
| const baseCount = parseInt(myOutput, 10) | |
| const absoluteIncrease = queryCount - baseCount | |
| const relativeIncrease = baseCount <= 0 ? 100 : (parseInt((absoluteIncrease / baseCount * 10000), 10) / 100) | |
| if (absoluteIncrease >= 100 || relativeIncrease > 5) { | |
| const comment = `🐢 Performance warning.\nIt looks like the query count of the integration tests increased with this PR.\nDatabase query count is now ` + queryCount + ' was ' + baseCount + ' (+' + relativeIncrease + '%)\nPlease check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.' | |
| github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| body: comment | |
| }) | |
| } | |
| if (queryCount < 100) { | |
| const comment = `🐈 Performance measuring seems broken. Failed to get query count.` | |
| github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| body: comment | |
| }) | |
| } |