-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] implement client dashboard api for notes #908
Conversation
Nice! How can I test this (i.e. which clients will use that API)? Is it for Nextcloud Android/iOS or for the Nextcloud server itself? The last one would be interesting, too, because currently, the dashboard app loads several megabytes Javascript for every widget. |
It can be used by any client, but first we will implement it on Android/iOS. |
Bug: iconURL is empty @icewind1991 |
Bug: notes icon url on widgets-items endpoint is empty |
a0636b0
to
6b3f457
Compare
@tobiasKaminsky I rebased and pushed a commit to fix the icon bugs. Mind to give this another test run? |
In {{ base_url }}/ocs/v2.php/apps/dashboard/api/v1/widgets: but it must be absolute, otherwise clients cannot use it. In: {{ base_url }}/ocs/v2.php/apps/dashboard/api/v1/widget-items |
I'm not sure if the previews would actually be useful here since they are quite small and you won't get the content in that size. Maybe having the star vs note icon makes more sense? @jancborchardt |
Co-authored-by: korelstar <korelstar@users.noreply.github.com> Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
0afb961
to
9e3f665
Compare
Dashboard api will allow clients to render the dashboard widgets
See nextcloud/server#33658 for more information, requires the interfaces added by that pr
This implementation was created to provide an example for a dashboard that has a button. Interfaces might still be subject to change.