Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #416

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #416

merged 1 commit into from
Dec 20, 2024

Conversation

nickvergessen
Copy link
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\…\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

@nickvergessen
fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…
ca9601c 
…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@nickvergessen nickvergessen merged commit 8b54445 into master Dec 20, 2024
21 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notification-handling branch December 20, 2024 14:33
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickvergessen nickvergessen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickvergessen