Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve key navigation and tabbing #2934

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

wofferl
Copy link
Collaborator

@wofferl wofferl commented Nov 25, 2024

Summary

  • add shortcuts 'enter' and 'esc' to open/close article details in compact mode
  • move shortcuts to list component to work also in compact mode
  • add icons in article details view to tab navigation

Checklist

@wofferl wofferl force-pushed the accessibility_key_navigation branch from 7105637 to dc2f0b8 Compare November 25, 2024 23:29
Signed-off-by: Wolfgang <github@linux-dude.de>
…n compact mode

Signed-off-by: Wolfgang <github@linux-dude.de>
Signed-off-by: Wolfgang <github@linux-dude.de>
…er accessibility

Signed-off-by: Wolfgang <github@linux-dude.de>
Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl force-pushed the accessibility_key_navigation branch from dc2f0b8 to 02a85a6 Compare November 26, 2024 20:00
@wofferl wofferl merged commit aa4af13 into nextcloud:master Nov 26, 2024
23 of 24 checks passed
Grotax added a commit that referenced this pull request Nov 27, 2024
Changed
- Items list style in compact mode to improve readability (and better match v24's style) (#2918)
- add shortcuts `e` or `enter` to open and `esc` to close article details in compact mode (#2934)

Fixed
- scrollbar in sidebar subscribe area / move new folder button in same area than subscribe (#2932)
- move shortcuts to list component to work also in compact mode (#2934)
- add proper title to icons in item list and details view for better accessibility (#2934)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Nov 27, 2024
Grotax added a commit that referenced this pull request Nov 27, 2024
Changed
- Items list style in compact mode to improve readability (and better match v24's style) (#2918)
- add shortcuts `e` or `enter` to open and `esc` to close article details in compact mode (#2934)

Fixed
- scrollbar in sidebar subscribe area / move new folder button in same area than subscribe (#2932)
- move shortcuts to list component to work also in compact mode (#2934)
- add proper title to icons in item list and details view for better accessibility (#2934)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@wofferl wofferl deleted the accessibility_key_navigation branch December 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants