Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of fixes for 25.0.0 #2913

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Set of fixes for 25.0.0 #2913

merged 9 commits into from
Nov 22, 2024

Conversation

wofferl
Copy link
Collaborator

@wofferl wofferl commented Nov 22, 2024

Summary

This PR also fixes:

  • don't add folder when already exist
  • disable subscribe button and show loading icon during adding feed process
  • don't show pinned feeds with no unread items when "Show all articles" is disabled
  • add missing shortcut 'shift + a' to mark all articles in current feed/folder read

Checklist

Signed-off-by: Wolfgang <github@linux-dude.de>
…d process

Signed-off-by: Wolfgang <github@linux-dude.de>
Signed-off-by: Wolfgang <github@linux-dude.de>
… is enabled

Signed-off-by: Wolfgang <github@linux-dude.de>
Signed-off-by: Wolfgang <github@linux-dude.de>
…cles" is disabled

Signed-off-by: Wolfgang <github@linux-dude.de>
… feed/folder read

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl added 3. to review frontend impact Javascript/Frontend code labels Nov 22, 2024
Signed-off-by: Wolfgang <github@linux-dude.de>
@Grotax Grotax merged commit be0d2d8 into nextcloud:master Nov 22, 2024
22 of 24 checks passed
Grotax added a commit that referenced this pull request Nov 24, 2024
Changed
- always show `All articles` route entry (#2913)
- remove confirmation dialog when mark read folders/feeds (#2913)
- add shortcut 'shift + a' to mark all articles in current feed/folder read (#2913)

Fixed
- shortcut 'r' not working in unread view when "Show all articles" is enabled (#2913)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Nov 24, 2024
Grotax added a commit that referenced this pull request Nov 24, 2024
Changed
- always show `All articles` route entry (#2913)
- remove confirmation dialog when mark read folders/feeds (#2913)
- add shortcut 'shift + a' to mark all articles in current feed/folder read (#2913)

Fixed
- shortcut 'r' not working in unread view when "Show all articles" is enabled (#2913)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@wofferl wofferl deleted the fixes_25 branch December 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review frontend impact Javascript/Frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortkey 'r' not working in unread view when "Show all articles" is enabled
3 participants