GUI Update: Select correct item in feed when loading feed with Newest First or Default Ordering #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Accalia <Accalia@Elementia.me>
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
=========================================
Coverage 91.62% 91.63%
- Complexity 778 780 +2
=========================================
Files 65 65
Lines 2724 2739 +15
=========================================
+ Hits 2496 2510 +14
- Misses 228 229 +1
Continue to review full report at Codecov.
|
SMillerDev
approved these changes
May 23, 2022
Grotax
approved these changes
May 24, 2022
|
@AccaliaDeElementia It seems this change breaks the item selection when "Reverse ordering(oldest on top)" is checked. If this checkbox is not selected, I think the behavior is expected. From the server response, it looks like the results are already sorted based on that setting, so I think we probably just wanna return the first item regardless what the ordering is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick update to ContentController.js to correctly set the active element when newest first or default ordering is active for a feed or view.
Should resolve #1324 by making behavior match expectations