Use Feed Link as GUID when Feed omits Guid. #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in nextcloud#1702 some feeds omit the GUID and are therefore not a valid RSS feed. nextcloud#1738 resolved the issue to allow valid feeds to update correctly when an invalid feed is present. This commit allows parsing of the invalid feed as well by assuming that the item link of the feed is unique to the feed and using it in place of the GUID when the feed omits the GUID. This will allow NextCloud News to accept and behave like many other popular feed aggregators when presented with such an invalid feed. Signed-off-by: Accalia <Accalia@Elementia.me>
AccaliaDeElementia
force-pushed
the
master
branch
from
ea5e7a3 to
e01ae49
Compare
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
============================================
+ Coverage 91.62% 91.66% +0.03%
- Complexity 778 781 +3
============================================
Files 65 65
Lines 2724 2746 +22
============================================
+ Hits 2496 2517 +21
- Misses 228 229 +1
Continue to review full report at Codecov.
|
Grotax
approved these changes
May 24, 2022
SMillerDev
reviewed
May 24, 2022
Signed-off-by: Accalia <Accalia@Elementia.me>
Signed-off-by: Accalia <Accalia@Elementia.me>
…for additional logging Signed-off-by: Accalia <Accalia@Elementia.me>
SMillerDev
approved these changes
May 24, 2022
Grotax
added a commit
that referenced
this pull request
May 29, 2022
Changed - Add API v1.3 adding routes for starring/unstarring items by id and general fixes (#1727) https://nextcloud.github.io/news/api/api-v1-3/ - Improve styling of tables in articles (#1779) - Allow fetching feeds that omit guid by using link as stand-in (#1785) Fixed - Fix updated api not returning any item after marking item as read (#1713) - Fix deprecation warning for strip_tags() on a null value (#1766) - Fix selected item being set incorrectly when using default ordering or newest first ordering (#1324) - Fix doubling the height of the content area (#1796) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
May 29, 2022
Changed - Add API v1.3 adding routes for starring/unstarring items by id and general fixes (#1727) https://nextcloud.github.io/news/api/api-v1-3/ - Improve styling of tables in articles (#1779) - Allow fetching feeds that omit guid by using link as stand-in (#1785) Fixed - Fix updated api not returning any item after marking item as read (#1713) - Fix deprecation warning for strip_tags() on a null value (#1766) - Fix selected item being set incorrectly when using default ordering or newest first ordering (#1324) - Fix doubling the height of the content area (#1796) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1702 some feeds omit the GUID and while they are
valid RSS feeds they are not maximally compatible with all feed readers as the
guid element is a recommednation in RSS 2.0 to allow deduplication of feeds.
#1738 resolved the issue above by allowing all other feeds to
update correctly when a feed that omits the guid element is present.
This commit allows parsing of the guid omitting feed as well by assuming
that the item link of the feed is unique to the feed and using
it in place of the GUID when the feed omits the GUID.
This will allow NextCloud News to accept and behave like many other
popular feed aggregators when presented with such a feed.