-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a task from a message #8375
Conversation
@ChristophWurst lmk if you think task.js and calendar.js should be moved calendar-js when you find time to review it |
@hamza221 if you can't pinpoint the warning and it doesn't influence the usability of the new feature create a ticket and we'll take a deeper dive in the stabilization phase. Let's get this feature in |
conflicts |
b839f24
to
ea956e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Didn't test
eslint needs a fix |
|
Create should be disabled if you have no calendars with VTODO support, I guess |
on it |
@JohannesGGE please re-review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The height of the description field could be increased so that it’s nicer to type in there, and that the "Create" button doesn’t float in the air but is exactly at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/TaskModal.vue
Outdated
</Multiselect> | ||
|
||
<br> | ||
<button class="primary" :disabled="saving" @click="onSave"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button class="primary" :disabled="saving" @click="onSave"> | |
<button class="primary" :disabled="disabled" @click="onSave"> |
Nit: Select option -> Select calendar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
Please squash |
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
c5e089d
to
772d293
Compare
closes #6127
Wait for Improvefollow-upNcCheckboxRadioSwitch
and use forNcAppSidebarTabs
nextcloud-libraries/nextcloud-vue#3945 to get merged and add the feature in Create event modal