Add horde_stringprep to support SCRAM-SHA-1 #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
enh/3146/scram-support
branch
from
4d19faf to
cfce705
Compare
| @@ -13,7 +13,8 @@ | |||
| "config": { | |||
| "platform": { | |||
| "php": "7.3" | |||
| } | |||
| }, | |||
| "sort-packages": true | |||
ChristophWurst
approved these changes
Jan 19, 2021
|
@kesselb rebase |
kesselb
force-pushed
the
enh/3146/scram-support
branch
from
cfce705 to
6882d2e
Compare
|
@ChristophWurst done. Small version bump for php-cs-fixer and new github url for webmozart. |
|
you rebased away your DCO sign off |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
enh/3146/scram-support
branch
from
6882d2e to
f747f5e
Compare
|
@kesselb: Thanks for SCRAM-SHA-1! Can you add other SCRAM? SHA-256/SHA-512/SHA3-512 and -PLUS variants too? Linked to: |
|
Hi @Neustradamus,
This depends on Horde ImapClient1 and their peer dependencies. Footnotes |
|
@kesselb: I wish you a Happy New Year 2024! Recently, there have been a lot of updates in PEAR about SCRAM. It is possible to look for Horde and Nextcloud? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3146
Horde_Imap_Client supports the SCRAM authentication mechanism but Horde_Stringprep as dependency is required (https://github.com/horde/Imap_Client/blob/e5302ee8b238f03564d0ea4177625214f79a3ebe/lib/Horde/Imap/Client/Auth/Scram.php#L98-L101).
If the server supports SCRAM-SHA-1 and the connection is unencrypted we are now able to use it.