Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows and only run required ones #1036

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 9, 2023

  1. Update the psalm workflow from the templates
  2. Update PHPUnit and the workflow from the templates
  • Drop all but sqlite as we do not have any database entries we do not need to run so many CI jobs
  • But for sqlite we test all supported PHP versions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb95410) 43.39% compared to head (17ab02b) 43.39%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1036   +/-   ##
=========================================
  Coverage     43.39%   43.39%           
  Complexity      168      168           
=========================================
  Files            26       26           
  Lines           689      689           
  Branches         31       31           
=========================================
  Hits            299      299           
  Misses          390      390           
Flag Coverage Δ
unit 25.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@come-nc come-nc merged commit 2fb5189 into master Nov 9, 2023
22 checks passed
@come-nc come-nc deleted the dependencies/psalm branch November 9, 2023 14:49
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants