-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for integration_app in nextcloud master #649
Conversation
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
4a261b9
to
cc8b722
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
28b4bcc
to
a86283d
Compare
b08c912
to
bcbe102
Compare
a27c70c
to
31184f5
Compare
31184f5
to
b2ef353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but CHANGELOG needs to be updated
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
b2ef353
to
df767f1
Compare
JS Code CoverageCoverage after merging add-support-for-master-nextcloud into master will be
Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
In this PR, following task is done:
safe
functions since NextCloud has removedtheCodingmachine/safe
chore(deps): Bump web-auth/webauthn-lib from 3.3.9 to 4.8.5 3rdparty#1799 (comment)Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.md
file