properly distinguish between inherited and unset permissions #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
fix/more-acl-ui-fixes
branch
from
3a19bc4 to
65df13f
Compare
artonge
approved these changes
Apr 2, 2024
… ACL ui Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
fix/more-acl-ui-fixes
branch
from
65df13f to
5bd536a
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a rule includes inherited permissions, but there is no parent permission set to inherit, the UI shows it the same as if there was an inherited "allow" permission.
This can lead to confusion as "no inherited permissions" and "inherited allow permissions" are handled different when merging the rules configured for multiple groups/users.
With this PR, "unset" permissions are shown as a dash.