Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress test for ACLs and trashbin #2650

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 30, 2023

No description provided.

@come-nc come-nc added the 2. developing Items that are currently under development label Nov 30, 2023
@come-nc come-nc self-assigned this Nov 30, 2023
@come-nc

This comment was marked as outdated.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/add-extensive-cypress-tests branch from cdaea1b to 99c7c08 Compare December 4, 2023 11:20
@come-nc
Copy link
Contributor Author

come-nc commented Dec 4, 2023

Reworked the tests, now 3 of them are failing waiting for the other PRs.
I’ve put the failing tests as skipped to get green CI and will unskip them in the related PRs.

@come-nc come-nc requested a review from artonge December 4, 2023 11:21
@come-nc come-nc added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Dec 4, 2023
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, code looks okay

@come-nc come-nc merged commit cf8e231 into master Dec 4, 2023
14 checks passed
@come-nc come-nc deleted the feat/add-extensive-cypress-tests branch December 4, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants