-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Drop need of user folder #2640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
2. developing
Items that are currently under development
bug
php
Items related to PHP updates and code issues
and removed
3. to review
Items that need to be reviewed
labels
Dec 7, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Closed
This was referenced Dec 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
artonge
force-pushed
the
artonge/fix/drop_userfolder_need
branch
from
December 13, 2023 15:39
fd276e2
to
398496e
Compare
artonge
force-pushed
the
artonge/fix/drop_userfolder_need
branch
from
December 13, 2023 15:51
398496e
to
b18ab21
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/drop_userfolder_need
branch
from
December 13, 2023 15:52
b18ab21
to
0158f02
Compare
Merged
@artonge what about to previously check if the entity does not already exists?
(or limited to |
come-nc
approved these changes
Dec 14, 2023
It would hide the reason |
Can this be backported to 27? |
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Items that are currently under development
bug
php
Items related to PHP updates and code issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions are bound to the groupfolder and not the current user. So we can get the
File
object without the current user folder.This helps in situations where no user is logged in, like background jobs.
Psalm errors already exist in stable28