Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if $user is set before calling it #2476

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Check if $user is set before calling it #2476

merged 1 commit into from
Jul 21, 2023

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jul 19, 2023 •
edited
Loading

Fix #2473

@solracsf solracsf mentioned this pull request Jul 19, 2023
Closed
@solracsf
Check if $user is set before calling it
354a239 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Remove blanks

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Blanks

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
Copy link
Member Author

/backport to stable27

@solracsf
Copy link
Member Author

/backport to stable26

@solracsf
Copy link
Member Author

/backport to stable25

@juergen852
Copy link

We experience this problem too.

@juliusknorr juliusknorr merged commit 41d493a into master Jul 21, 2023
@juliusknorr juliusknorr deleted the getUserAcl branch July 21, 2023 10:09
This was referenced Jul 21, 2023
Merged
Merged
Merged
@BJKle
Copy link

BJKle commented Jul 25, 2023

Is there a release date?

@fromanm1
Copy link

I found the option scan of gropupfolders didn't work because we just lost 6tb of data, I restore a backup and when I want to rescan the directories I almost have a heart attack.

Thank you for the fix, I really needed.

@rainerjung rainerjung mentioned this pull request Jul 26, 2023
Closed
@TP75 TP75 mentioned this pull request Jul 27, 2023
Closed
@BJKle
Copy link

BJKle commented Jul 29, 2023

Is there a release date?

@solracsf Can you provide an answer? Thank you

@solracsf
Copy link
Member Author

solracsf commented Jul 29, 2023 •
edited
Loading

Is there a release date?

No. You can apply the patch manually.

@solracsf solracsf mentioned this pull request Jul 29, 2023
Closed
@quenenni
Copy link

Is there a release date?

No. You can apply the patch manually.

Please, that's not serious.
I updated half of our 500 clouds and now I have lots of cron errors all the time.
I'm afraid to update the other part.
That's a shitty situation. Nextcloud forced us to update our v24 clouds because of the new aggresive security politic and if I upgrade to v25 or to v26, I have errors with this plugin. :'(

Can you please do a new minor version with this fix.

@juergen852
Copy link

juergen852 commented Jul 31, 2023 •
edited
Loading

No. You can apply the patch manually.

Would love to do that, but how ??
Can you please explain for "normal" admins?
Or is this fixed in 27.0.1 ?

@BJKle
Copy link

BJKle commented Aug 1, 2023

Is there a release date?

No. You can apply the patch manually.

Please, that's not serious. I updated half of our 500 clouds and now I have lots of cron errors all the time. I'm afraid to update the other part. That's a shitty situation. Nextcloud forced us to update our v24 clouds because of the new aggresive security politic and if I upgrade to v25 or to v26, I have errors with this plugin. :'(

Can you please do a new minor version with this fix.

@icewind1991 I‘ve seen you prepared new releases. Could you create one with this patch included? Thanks

@ChristophWurst
Copy link
Member

Would love to do that, but how ??

https://docs.nextcloud.com/server/latest/admin_manual/issues/applying_patch.html#patching-apps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@nextcloud nextcloud locked as resolved and limited conversation to collaborators Aug 3, 2023
@solracsf
Copy link
Member Author

Fix has been released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
bug feedback-requested regression
Projects
None yet
Milestone
No milestone
7 participants
@solracsf @juergen852 @BJKle @fromanm1 @quenenni @ChristophWurst @juliusknorr