enable encryption with system keys for groupfolders #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
system-key-encryption
branch
from
f57f063 to
f3d60be
Compare
|
Changed it so encryption is disabled by default to prevent unexpected behavior change on upgrade |
icewind1991
force-pushed
the
system-key-encryption
branch
from
f3d60be to
5a48224
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
system-key-encryption
branch
from
5a48224 to
2df8760
Compare
|
"backport" is here: #2068 |
PVince81
reviewed
Aug 25, 2022
| @@ -78,6 +78,7 @@ public function register(IRegistrationContext $context): void { | |||
| }; | |||
| $config = $c->get(IConfig::class); | |||
| $allowRootShare = $config->getAppValue('groupfolders', 'allow_root_share', 'true') === 'true'; | |||
| $enableEncryption = $config->getAppValue('groupfolders', 'enable_encryption', 'false') === 'true'; | |||
There was a problem hiding this comment.
I'm wondering if we should also bring this to the web UI as it will likely be a more common option than allow_root_share ?
There was a problem hiding this comment.
Yes, I am in favor. I would look for it there.
|
@CarlSchwan can you review this one with the server one also ? |
CarlSchwan
approved these changes
Aug 29, 2022
This was referenced Dec 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably possible to do some backwards compatibility hack to keep compatibility with versions that don't have the marker interface