Skip to content

Commit

Permalink
Merge pull request #2907 from nextcloud/backport/2904/stable29
Browse files Browse the repository at this point in the history
[stable29] Even more acl ux fixes
  • Loading branch information
icewind1991 authored Apr 3, 2024
2 parents 981a743 + aa36662 commit c490e90
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,10 @@ class AclDavService {
inheritedAclsById[id] = acl
if (aclsById[id] == null) {
aclsById[id] = acl

aclsById[id].inheritedMask = acl.mask
aclsById[id].inheritedPermissions = acl.permissions
aclsById[id].mask = 0
} else {
aclsById[id].inheritedMask = acl.mask
aclsById[id].inheritedPermissions = acl.permissions
Expand Down
5 changes: 2 additions & 3 deletions src/components/SharingSidebarView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,10 @@
</template>
{{ t('groupfolders', 'Add advanced permission rule') }}
</NcButton>
<NcSelect v-if="isAdmin && !loading"
v-show="showAclCreate"
<NcSelect v-if="isAdmin && !loading && showAclCreate"
ref="select"
v-model="value"
:options="options"
:clear-search-on-select="true"
:loading="isSearching"
:filterable="false"
:placeholder="t('groupfolders', 'Select a user or group')"
Expand Down Expand Up @@ -312,6 +310,7 @@ export default {
})
},
createAcl(option) {
this.value = null
const rule = new Rule()
rule.fromValues(option.type, option.id, option.displayname, 0b00000, 0b11111)
this.list.push(rule)
Expand Down

0 comments on commit c490e90

Please sign in to comment.