Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy link support #2355

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

Chartman123
Copy link
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 self-assigned this Oct 5, 2024
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Oct 5, 2024
@Chartman123 Chartman123 added this to the 5.0 milestone Oct 5, 2024
@Chartman123 Chartman123 added the technical debt Technical issue label Oct 5, 2024
@Chartman123 Chartman123 requested review from hamza221, Koc and susnux October 5, 2024 18:16
@Chartman123 Chartman123 linked an issue Oct 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d5de048). Learn more about missing BASE report.
Report is 140 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage        ?   35.66%           
  Complexity      ?     1021           
=======================================
  Files           ?       72           
  Lines           ?     3866           
  Branches        ?        0           
=======================================
  Hits            ?     1379           
  Misses          ?     2487           
  Partials        ?        0           

@Chartman123 Chartman123 force-pushed the chore/remove-legacyLink branch from df279a9 to 73e416d Compare October 5, 2024 19:19
lib/Constants.php Outdated Show resolved Hide resolved
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the chore/remove-legacyLink branch from 03bd7ae to c732219 Compare October 11, 2024 21:54
@Chartman123
Copy link
Collaborator Author

Chartman123 commented Oct 11, 2024

@susnux all comments should be fixed now, thanks for the review :)

Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and a quick tests also worked :)

@Chartman123 Chartman123 merged commit cc5eadc into main Oct 12, 2024
50 checks passed
@Chartman123 Chartman123 deleted the chore/remove-legacyLink branch October 12, 2024 16:12
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feedback-requested technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacyLink related code
2 participants