Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ask for restarting submission if form was changed #2319

Merged

Conversation

Koc
Copy link
Collaborator

@Koc Koc commented Sep 11, 2024

This is a follow-up for #2312 based on a comment #2312 (comment)

nextcloud-reset-demo-2024-09-23_01.49.44.mp4

🎁 Bonus

Added reset button

src/views/Submit.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Koc

nice work. A few wordings changed :) Not tested yet, will do this this evening :)

src/views/Submit.vue Outdated Show resolved Hide resolved
src/views/Submit.vue Outdated Show resolved Hide resolved
src/views/Submit.vue Outdated Show resolved Hide resolved
src/views/Submit.vue Outdated Show resolved Hide resolved
@Chartman123 Chartman123 added this to the 5.0 milestone Sep 12, 2024
@Chartman123 Chartman123 added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress feature: 📝 submitting responses labels Sep 12, 2024
@Koc Koc force-pushed the feature/restart-form-submission-on-change branch 3 times, most recently from dceffce to ffc0ad6 Compare September 22, 2024 23:48
@Koc
Copy link
Collaborator Author

Koc commented Sep 22, 2024

🗒️ Changes:

  • fixed code review comments
  • added reset button
  • added 🎥 video with demo

cc @Chartman123

@Koc Koc force-pushed the feature/restart-form-submission-on-change branch from ffc0ad6 to dd9fc3a Compare September 22, 2024 23:59
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little comments, will test it later :)

src/views/Submit.vue Outdated Show resolved Hide resolved
src/views/Submit.vue Show resolved Hide resolved
@Chartman123 Chartman123 changed the title Ask for restarting submission if form was changed feat: Ask for restarting submission if form was changed Sep 24, 2024
@Koc Koc force-pushed the feature/restart-form-submission-on-change branch 2 times, most recently from e0bfa40 to 3380067 Compare September 28, 2024 22:06
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/restart-form-submission-on-change branch from 3380067 to f7fe8cd Compare October 1, 2024 09:58
@Chartman123 Chartman123 merged commit 47a4435 into nextcloud:main Oct 5, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request feature: 📝 submitting responses javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants