Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: make show to all users an admin setting #2306

Merged
merged 1 commit into from
Aug 31, 2024
Merged

enh: make show to all users an admin setting #2306

merged 1 commit into from
Aug 31, 2024
+41 −2

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Aug 31, 2024 •
edited
Loading

  • Permit to all can be controlled by an admin setting
  • Makes sense to me to control also "show to all" using an admin setting

Replaces original PR #1906 by @akhil1508 where we didn't get any response anymore

@codecov Codecov
Copy link

codecov bot commented Aug 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b528a54). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage        ?   36.20%           
  Complexity      ?     1009           
=======================================
  Files           ?       68           
  Lines           ?     3806           
  Branches        ?        0           
=======================================
  Hits            ?     1378           
  Misses          ?     2428           
  Partials        ?        0

@Chartman123
enh: make show to all users an admin setting
ee697ff 
Signed-off-by: GitHub <noreply@github.com>
@Chartman123 Chartman123 added enhancement New feature or request 3. to review Waiting for reviews feature: 👥 sharing settings labels Aug 31, 2024
@Chartman123 Chartman123 added this to the 4.3 milestone Aug 31, 2024
@Chartman123 Chartman123 marked this pull request as ready for review August 31, 2024 18:40
susnux
susnux approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Chartman123 Chartman123 merged commit 29072ab into main Aug 31, 2024
51 checks passed
@Chartman123 Chartman123 deleted the enh/configShowToAllUsers branch August 31, 2024 19:51
@akhil1508
Copy link

Thanks a lot @Chartman123 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 👥 sharing settings
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Chartman123 @akhil1508 @susnux