Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warning about removing legacy links #2277

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Aug 11, 2024

This fixes #2071 by adding a warning NoteCard to submit/create view for forms with legacyLink enabled.

grafik

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added enhancement New feature or request design Related to the design labels Aug 11, 2024
@Chartman123 Chartman123 added the 3. to review Waiting for reviews label Aug 11, 2024
@Chartman123 Chartman123 self-assigned this Aug 11, 2024
@Chartman123 Chartman123 added this to the 4.3 milestone Aug 11, 2024
@Chartman123 Chartman123 requested a review from susnux August 11, 2024 09:38
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two comments but no blockers

@Chartman123 Chartman123 force-pushed the feat/warnLegacyLink branch 4 times, most recently from 2079936 to 640cd7e Compare August 11, 2024 14:28
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 merged commit 7004196 into main Aug 11, 2024
42 checks passed
@Chartman123 Chartman123 deleted the feat/warnLegacyLink branch August 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: 👥 sharing settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of legacyLink access
2 participants