fix(TopBar): provide optional button text via new slot syntax #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Chartman123
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Can confirm that this fixes it :) Thank you very much @ShGKme!
|
/backport to stable3 |
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue on
NcButtonside, but can also be fixed here. Passing conditional content always works better with explicit no-passing slot completely.It is an old known issue in Vue 2 with deprecated slot syntax and checking
this.$slots. Because there is a content passed via old slot syntax (not usingv-slotdirective), it handles$slotsdifferently. It has icon rendering function in$scopedSlots, but the rendering result does not exist in$slots.Unfortunately, I don't remember the Vue 2 issue link...