-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse top bar component for responses view toggle #1576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @susnux! :) Only 2 things:
- On the "after" screenshot, the overall border is overlapped by the slight blue background of the selected item. It would look better if the selected item is fully within the border. Like in the View/Edit/Results switcher, see "After" video of More usable and accessible navigation between View/Edit/Results #1381
- It would probably be best to move this into the Vue components library directly? Cause I’d say this would look great for the tab navigation in the right sidebar as well, like in Files and Talk – what do you think @nimishavijay @marcoambrosini?
Also @susnux a similar component was discussed at nextcloud-libraries/nextcloud-vue#603 (comment), cc @raimund-schluessler for reference. :) |
bbc497c
to
86b8843
Compare
This will then require |
86b8843
to
01e4e8f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Split TopBar into TopBar and reuseable PillMenu, and reuse for responses view selector. The toggle is now based on the NcCheckboxRadioSwitch component Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
01e4e8f
to
13e4b2b
Compare
This is an alternative for #1559 to reuse the top bar menu. I split the
TopBar
component intoTopBar
and a reusablePillMenu
component.Why?