Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move API to v2.1 #1539

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Move API to v2.1 #1539

merged 1 commit into from
Mar 1, 2023

Conversation

Chartman123
Copy link
Collaborator

This fixes #1538 by moving all endpoints to v2.1 and allowing v2 for old endpoints

@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket javascript Javascript related ticket 2. developing Work in progress labels Feb 28, 2023
@Chartman123 Chartman123 added this to the 3.2 milestone Feb 28, 2023
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 28, 2023
@Chartman123 Chartman123 marked this pull request as ready for review February 28, 2023 21:52
@jotoeri
Copy link
Member

jotoeri commented Feb 28, 2023

That was fast, thank you! :)

https://github.com/nextcloud/forms/blob/4cfb47b277d7c43bbf74b8854c68ab9f7f030d62/lib/Capabilities.php#LL45-L45C28
-> Capabilities still needs an additional v2.1

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@jotoeri jotoeri modified the milestones: 3.2, 3.1.1 Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1539 (8cffecc) into main (4cfb47b) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1539   +/-   ##
=========================================
  Coverage     40.17%   40.17%           
  Complexity      560      560           
=========================================
  Files            54       54           
  Lines          2367     2367           
=========================================
  Hits            951      951           
  Misses         1416     1416           

@Chartman123 Chartman123 merged commit 20206cf into main Mar 1, 2023
@Chartman123 Chartman123 deleted the fix/apiVersion branch March 1, 2023 09:12
@jotoeri jotoeri modified the milestones: 3.1.1, 3.2 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API v2.1 not fully evolved
2 participants