Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timestamp in csv export ISO 8601 compliant #1531

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Make timestamp in csv export ISO 8601 compliant #1531

merged 1 commit into from
Mar 5, 2023

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Feb 21, 2023 •
edited
Loading

Fixes #1482

  • Fix csv export
  • Adjust tests

@Chartman123 Chartman123 added this to the 3.2 milestone Feb 21, 2023
@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket 2. developing Work in progress labels Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #1531 (b6715b7) into main (077f359) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b6715b7 differs from pull request most recent head 68b8140. Consider uploading reports for the commit 68b8140 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1531      +/-   ##
============================================
- Coverage     40.17%   40.15%   -0.03%     
  Complexity      560      560              
============================================
  Files            54       54              
  Lines          2367     2366       -1     
============================================
- Hits            951      950       -1     
  Misses         1416     1416

@Chartman123
Copy link
Collaborator Author

@jotoeri should we put this one also into 3.1.1?

@jotoeri
Copy link
Member

jotoeri commented Mar 1, 2023

@jotoeri should we put this one also into 3.1.1?

Hmm. I think i wouldn't do this. It's actually not clear if this is a bug, or just a decision we took. I think we even talked about somewhen. And if people are somehow used to the current format, then this shouldn't change just by a patch release. So i think i'd keep it for 3.2.

@Chartman123 Chartman123 marked this pull request as ready for review March 1, 2023 21:36
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 1, 2023
@Chartman123 Chartman123 requested a review from susnux March 1, 2023 21:38
@Chartman123
Copy link
Collaborator Author

@jotoeri Yes, makes more sense to have it in the same order as in the csv 👍🏻

I've worked in your comments now

@Chartman123 @jotoeri
Make timestamp in csv export ISO 8601 compliant
68b8140 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@jotoeri
Copy link
Member

jotoeri commented Mar 5, 2023

Just found, that we merged enhancements already. So it'll anyways become 3.2.0 🙈

@susnux
Copy link
Collaborator

susnux commented Mar 5, 2023

we merged enhancements already

The lastUpdated property was an enhancement I guess?

@jotoeri jotoeri modified the milestones: 3.2, 3.3 Mar 5, 2023
@jotoeri jotoeri merged commit b6597d1 into main Mar 5, 2023
@jotoeri jotoeri deleted the fix/exportCsvTimestamp branch March 5, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@jotoeri jotoeri jotoeri approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request php PHP related ticket
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Timestamp in CSV export should follow ISO 8601
3 participants
@Chartman123 @jotoeri @susnux