refactor lastUpdated for Questions

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>

lib/Controller/ApiController.php

@@ -503,8 +503,6 @@ public function newQuestion(int $formId, ?string $type = null, string $text = ''
 			}
 		}
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($response);
 	}
 
@@ -573,7 +571,6 @@ public function updateQuestion(int $formId, int $questionId, array $keyValuePair
 		$question->setId($questionId);
 
 		// Update changed Columns in Db.
-		$this->formMapper->update($form);
 		$this->questionMapper->update($question);
 
 		return new DataResponse($question->getId());
@@ -630,8 +627,6 @@ public function deleteQuestion(int $formId, int $questionId): DataResponse {
 			}
 		}
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($questionId);
 	}
 
@@ -719,8 +714,6 @@ public function reorderQuestions(int $formId, array $newOrder): DataResponse {
 			];
 		}
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($response);
 	}
 
@@ -1676,8 +1669,6 @@ public function newQuestionLegacy(int $formId, string $type, string $text = ''):
 		$response['options'] = [];
 		$response['accept'] = [];
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($response);
 	}
 
@@ -1765,8 +1756,6 @@ public function reorderQuestionsLegacy(int $formId, array $newOrder): DataRespon
 			];
 		}
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($response);
 	}
 
@@ -1831,8 +1820,6 @@ public function updateQuestionLegacy(int $id, array $keyValuePairs): DataRespons
 		// Update changed Columns in Db.
 		$this->questionMapper->update($question);
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($question->getId());
 	}
 
@@ -1883,8 +1870,6 @@ public function deleteQuestionLegacy(int $id): DataResponse {
 			}
 		}
 
-		$this->formMapper->update($form);
-
 		return new DataResponse($id);
 	}
 

lib/Db/QuestionMapper.php

@@ -27,6 +27,7 @@
 namespace OCA\Forms\Db;
 
 use OCP\AppFramework\Db\DoesNotExistException;
+use OCP\AppFramework\Db\Entity;
 use OCP\AppFramework\Db\QBMapper;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IDBConnection;
@@ -37,17 +38,39 @@
 class QuestionMapper extends QBMapper {
 	public function __construct(
 		IDBConnection $db,
+		private FormMapper $formMapper,
 		private OptionMapper $optionMapper
 	) {
 		parent::__construct($db, 'forms_v2_questions', Question::class);
 	}
 
+	/**
+	 * @param Entity $entity
+	 * @psalm-param Question $entity
+	 * @return Question
+	 * @throws \OCP\DB\Exception
+	 */
+	public function insert(Entity $entity): Question {
+		$this->formMapper->update($this->formMapper->findById($entity->getFormId()));
+		return parent::insert($entity);
+	}
+
+	/**
+	 * @param Entity $entity
+	 * @psalm-param Question $entity
+	 * @return Question
+	 * @throws \OCP\DB\Exception
+	 */
+	public function update(Entity $entity): Question {
+		$this->formMapper->update($this->formMapper->findById($entity->getFormId()));
+		return parent::update($entity);
+	}
+
 	/**
 	 * @param int $formId
 	 * @throws DoesNotExistException if not found
 	 * @return Question[]
 	 */
-
 	public function findByForm(int $formId, bool $loadDeleted = false): array {
 		$qb = $this->db->getQueryBuilder();