-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix modal on mobile and a button #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mobile version looks good, but the icon in the "next" button seems too far to the left?
And for the desktop version, introducing a big dedicated space for the button looks a bit off. The overlap is fine, we just need to have nicer placing.
On tech-preview it looks like this, floating in the bottom right of the modal, which is actually great, and it scrolls so all fine. (Only weird thing is the logo is missing)
d11e7aa
to
1865f01
Compare
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1865f01
to
2498d2e
Compare
Close nextcloud/server#33828 and another issue with the button.
Signed-off-by: szaimen szaimen@e.mail.de