Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Remove encodeURI code #397

Merged
merged 1 commit into from
May 25, 2021
Merged

[stable21] Remove encodeURI code #397

merged 1 commit into from
May 25, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 25, 2021 •
edited by MorrisJobke
Loading

backport of #384

@skjnldsv
Copy link
Member

/compile amend /

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 21.0.3 milestone May 25, 2021
@beardhatcode @npmbuildbot-nextcloud
Remove encodeURI code
507ffd4 
The errors that required encodeURIComponent in the past have been
mittigated by the following commit on nextcloud viewer.

nextcloud/viewer@02e1b1a

The code with hasScheme may be removed, viewer now returns a full
properly encoded URI thanks to the work done in nextcloud-router

fixes #381

Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/384/stable21 branch from f4b2893 to 507ffd4 Compare May 25, 2021 15:13
@beardhatcode
Copy link
Contributor

I'm confused, why are there changes in files_pdfviewer-public.js? In the original PR only one file in JS was edited.

@skjnldsv
Copy link
Member

I'm confused, why are there changes in files_pdfviewer-public.js? In the original PR only one file in JS was edited.

Can be outdated branch builds 🤷

@skjnldsv skjnldsv merged commit 9ddbfd8 into stable21 May 25, 2021
@skjnldsv skjnldsv deleted the backport/384/stable21 branch May 25, 2021 15:55
@beardhatcode beardhatcode linked an issue May 26, 2021 that may be closed by this pull request
Invalid PDF structure when inside a folder containing a '#' #254
Closed
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@beardhatcode beardhatcode Awaiting requested review from beardhatcode

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release bug javascript
Projects
None yet
Milestone
Nextcloud 21.0.3
Development

Successfully merging this pull request may close these issues.

Invalid PDF structure when inside a folder containing a '#'
3 participants
@skjnldsv @beardhatcode @LukasReschke