Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove reference to ILogger #782

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 25, 2024

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge added 3. to review Waiting for reviews technical debt Technical issue php Pending a documentation update/fix labels Sep 25, 2024
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this pass before, the constructor in FileService has been gone since several years 🙈

@artonge artonge merged commit c7a42c9 into master Sep 26, 2024
38 checks passed
@artonge artonge deleted the artonge/chore/remove_reference_to_ilogger branch September 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews php Pending a documentation update/fix technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILogger is deprecated and will be removed
2 participants