Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(chunk): Add docs for chunked upload v2 #10740

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 13, 2023

Add documentation for nextcloud/server#27034

🖼️ Screenshots

image

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

developer_manual/client_apis/WebDAV/chunking.rst Outdated Show resolved Hide resolved
developer_manual/client_apis/WebDAV/chunking.rst Outdated Show resolved Hide resolved
developer_manual/client_apis/WebDAV/chunking.rst Outdated Show resolved Hide resolved
developer_manual/client_apis/WebDAV/chunking.rst Outdated Show resolved Hide resolved
developer_manual/client_apis/WebDAV/chunking.rst Outdated Show resolved Hide resolved
@@ -60,7 +158,7 @@ Assembling the chunk on the server is a matter of initiating a move from the cli
The server will now assemble the chunks and move the final file to the folder ``dest/file.zip``.

If a modification time should be set, you can by adding it as header with date as unixtime:
``curl -X MOVE -u roeland:pass --header 'X-OC-Mtime:1547545326' --header 'Destination:https://server/remote.php/dav/files/roeland/dest/file.zip' https://server/remote.php/dav/uploads/roeland/myapp-e1663913-4423-4efe-a9cd-26e7beeca3c0/.file``"
``curl -X MOVE -u roeland:pass --header 'X-OC-Mtime:1547545326' --header 'Destination:https://server/remote.php/dav/files/roeland/dest/file.zip' https://server/remote.php/dav/uploads/roeland/myapp-e1663913-4423-4efe-a9cd-26e7beeca3c0/.file``"
Otherwise the current upload date will be used as modification date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload date is the date of the first/last file uploaded or when the MOVE command is passed?

@tflidd
Copy link
Contributor

tflidd commented Jul 17, 2023

Nice comprehensible write-up with example code for this feature 👍

What is not clear, if your connection is interrupted and you want to continue to upload the data, how long will Nextcloud keep the chunks? There probably is some clean up routine. I imagine you can just check if the upload folder is still present (what was mentioned in the beginning). Perhaps too obvious?

@juliusknorr
Copy link
Member Author

What is not clear, if your connection is interrupted and you want to continue to upload the data, how long will Nextcloud keep the chunks? There probably is some clean up routine. I imagine you can just check if the upload folder is still present (what was mentioned in the beginning). Perhaps too obvious?

I'll clarify that, there is actually also depend on the storage (e.g. s3) policies how long the multipart uploads are kept. On the Nextcloud side we expire them after 24 hours

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Added a note about expiring upload folders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants