Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch client side encryption to use sha256 hash algorithm #7780

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mgallien
Copy link
Collaborator

Close #5989

only support sha1 for depreceted read-only usage

use sha256 for new encrypted write operations

@mgallien mgallien added this to the 3.16.0 milestone Jan 22, 2025
@mgallien mgallien force-pushed the feature/cleanDeprecatedHashAlgorithm branch from fd2f0d3 to bebf18d Compare January 22, 2025 10:39
@mgallien mgallien self-assigned this Jan 22, 2025
Close #5989

only support sha1 for depreceted read-only usage

use sha256 for new encrypted write operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/cleanDeprecatedHashAlgorithm branch from bebf18d to 6cc7a99 Compare January 23, 2025 09:47
@mgallien mgallien enabled auto-merge January 23, 2025 09:47
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7780-6cc7a9955f72561beb84d519504a68e5c921229f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
E Maintainability Rating on New Code (required ≥ A)
113 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit af4aff8 into master Jan 23, 2025
13 of 17 checks passed
@mgallien mgallien deleted the feature/cleanDeprecatedHashAlgorithm branch January 23, 2025 11:13
@mgallien mgallien mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: E2EE uses deprecated SHA-1 algorithm for it's CSR, breaking RHEL 9 compat
4 participants