Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Improves texts displayed to the user when picking the wrong location for syncing #7596

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

UI: Improves texts displayed to the user when picking the wrong location for syncing #7596

wants to merge 9 commits into from
+63 −51

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Dec 2, 2024 •
edited
Loading

⚠️ It depends on #7636 ⚠️

Improves texts displayed to the user when picking the wrong location for syncing:

  • User has no permissions to write to local folder:

noperms

  • The sync folder in the network:

network-location

  • Local folder does not exist:

doesnotexist

  • Trying to sync to the same folder locally:

double-sync

  • Folder contained in sync folder:

contained

  • Network drive/root:

drive2

  • Folder is already syncing to:

already-synced2

  • Root folder is already syncing:

root-synced

Rello
Rello reviewed Dec 3, 2024
View reviewed changes
src/common/vfs.cpp Outdated Show resolved Hide resolved
@camilasan camilasan marked this pull request as ready for review December 4, 2024 21:42
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7596-f57f894fee3403f640a494ea57c6ddb3cd339d8c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan self-assigned this Dec 9, 2024
@camilasan camilasan added this to the 3.16.0 milestone Dec 10, 2024
@camilasan camilasan changed the title Bugfix network sync folder detection Improves texts displayed to the user when picking the wrong location for syncing Dec 11, 2024
@camilasan camilasan changed the title Improves texts displayed to the user when picking the wrong location for syncing UI: Improves texts displayed to the user when picking the wrong location for syncing Dec 11, 2024
@camilasan camilasan mentioned this pull request Jan 27, 2025
Closed
8 tasks
nilsding
nilsding requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two nits

src/common/vfs.cpp Outdated Show resolved Hide resolved
src/gui/folderwizard.cpp Outdated Show resolved Hide resolved
@camilasan
Improve text returned when checking VFS availability.
04c395a 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve text when returning error on checking local path.
2375e34 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve error/warning text when adding sync folder.
b05cb24 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve error strings when selecting remote folder.
91162e7 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Modernize FolderWizardRemotePath::isComplete().
21393a7 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Display the local folder path when warning that folder is already bei…
3e8137a 
…ng synced.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Use std::as_const.
a4e07c0 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Imprivew FormatWarningsWizardPage::formatWarnings.
65b4e78 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Fix typo.
de9cd04 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7596.zip

SHA256 checksum: aa6fa9ee6fefa585c33cfccb388c325d1706247b8e5eccc47eb0b6f04aa29650

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rello Rello Rello left review comments

@nilsding nilsding nilsding approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@camilasan camilasan

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@camilasan @nextcloud-desktop-bot @nilsding @Rello