Feature/add edit button #1566
Closed
Feature/add edit button #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… emit the sign like the code was supposed to. Signed-off-by: Mariana Meireles <mariana@psychonautgirl.space>
Signed-off-by: Mariana Meireles <mariana@psychonautgirl.space>
marimeireles
force-pushed
the
feature/add-edit-button
branch
from
5bf9005 to
f6feaf5
Compare
|
@marimeireles is this based on what @camilasan did at #1442 or does it replace it? Or is both needed? :) |
|
As far as I'm concerned this is a different thing. Gonna try to work on this now, sorry, I was on vacation and lost track of things. |
|
But wait a second.. @camilasan is this still relevant for the new NextCloud desktop version? |
|
@marimeireles yeah it should be, or why not? :) Are you referring to Virtual drive, or the new tray menu? Neither of those make a right-click → Edit functionality obsolete, as far as I can see. :) |
|
Doesn't apply anymore on master, a new approach would need to be taken. Please feel free to open a new PR related to that and sorry for that lost effort... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: #1524
So @camilasan can check my progress :)