Skip to content

Conversation

Ayyoubzadeh
Copy link

  • Resolves: #
  • Target version: main

Summary

This PR adds comprehensive Jalali calendar (Persian/Shamsi calendar) support to the Deck application, enabling Persian-speaking users to work with their native calendar system while maintaining full backward compatibility.

Key Features:

  • Automatic Locale Detection: Seamlessly switches between Gregorian and Jalali calendars based on user locale
  • Persian Calendar Integration: Full support for Jalali date conversion, formatting, and display
  • Enhanced Components: New due date selector and badge components with calendar-aware functionality
  • Localized Experience: Persian day names, month names, and relative time expressions
  • Backward Compatibility: Existing functionality remains unchanged for non-Persian locales

Technical Implementation:

  • Added moment-jalaali dependency for Jalali calendar calculations
  • Created jalaliCalendar.js helper with comprehensive date conversion functions
  • Implemented enhancedReadableDate mixin for calendar-aware date formatting
  • Enhanced existing components (EnhancedDueDateSelector, EnhancedDueDate) with Jalali support
  • Added automatic initialization system that detects locale changes
  • Comprehensive test coverage for all calendar functions
  • Full documentation in docs/JALALI_CALENDAR.md

User Experience:

  • Persian users automatically see Jalali calendar dates throughout the application
  • Due dates, timestamps, and relative times are displayed in Persian format
  • Week starts on Saturday (as per Persian calendar tradition)
  • All date pickers and displays respect the user's calendar preference

TODO

  • Update Persian localization files with new calendar-related strings
  • Add visual calendar grid picker for Jalali dates (future enhancement)
  • Consider adding Persian holiday support
  • Performance testing with large date ranges
  • User acceptance testing with Persian-speaking users

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required
  • Backward compatibility maintained
  • Locale detection properly implemented
  • Date conversion functions tested
  • Component integration verified
  • Error handling implemented
  • Performance considerations addressed

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant