refactor: Migrate away from deprecated ILogger interface to PSR-3
#6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
juliushaertl,
a team and
max-nextcloud
and removed request for
a team
susnux
force-pushed
the
refactor/migrate-away-from-ILogger
branch
from
5cee0b7
to
0cf0b17
Compare
Mostly replace `ILogger` with `LoggerInterface` and some minor cleanup (constructor property promotion). Some places used the deprecated `logException` this is easy to migrate by simply use the appropriate loglevel on the logger and place the exception under the `exception` key in the context. Also the manual checking of the configured log level is not needed, as this is already done by the logger. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/migrate-away-from-ILogger
branch
from
0cf0b17
to
beb563e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly replace
ILoggerwithLoggerInterfaceand some minor cleanup (constructor property promotion).Some places used the deprecated
logExceptionthis is easy to migrate by simply use the appropriate log level on the logger and place the exception under theexceptionkey in the context.Also the manual checking of the configured log level is not needed, as this is already done by the logger.
Checklist