Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow empty card titles #611

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Don't allow empty card titles #611

merged 3 commits into from
Oct 9, 2018

Conversation

weeman1337
Copy link
Member

Summary

  • stores the titles temporarily when editing
    • if the new title is empty it restores the previous one
    • if the new title is not empty it commits the changes
  • enables the browser form validations to work on "enter"

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • [-] Tests (unit, integration, api and/or acceptance) are included
  • [-] Documentation (manuals or wiki) has been updated or is not required

@weeman1337 weeman1337 added the bug label Sep 6, 2018
@weeman1337 weeman1337 added this to the 0.4.2 milestone Sep 6, 2018
@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #611 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   76.07%   76.07%           
=======================================
  Files          57       57           
  Lines        2474     2474           
=======================================
  Hits         1882     1882           
  Misses        592      592

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@juliusknorr juliusknorr force-pushed the bug/589/empty-titles branch from f855a38 to a02bd5a Compare October 9, 2018 09:32
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks @weeman1337

@juliusknorr juliusknorr modified the milestones: 0.4.2, 0.5.0 Oct 9, 2018
@juliusknorr juliusknorr changed the title Bug/589/empty titles Don't allow empty card titles Oct 9, 2018
@juliusknorr juliusknorr mentioned this pull request Oct 9, 2018
33 tasks
@juliusknorr juliusknorr merged commit 014e7e4 into master Oct 9, 2018
@juliusknorr juliusknorr deleted the bug/589/empty-titles branch October 9, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants