Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the compact mode #602

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Adds the compact mode #602

merged 2 commits into from
Aug 29, 2018

Conversation

weeman1337
Copy link
Member

Summary

Adds a compact mode toggle:

standard view and toggle
image

compact mode
image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included (no frontend tests, yet)
  • Documentation (manuals or wiki) has been updated or is not required

Possible follow ups

  • introduce some JS in the core, that allows storing user settings
  • update deck to persist the compact mode state

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files          52       52           
  Lines        1969     1969           
=======================================
  Hits         1486     1486           
  Misses        483      483

css/style.scss Outdated
@@ -338,7 +348,7 @@ input.input-inline {
flex-direction: column;

h3 {
padding: 10px 10px 8px;
padding: 10px 10px 8px;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate ;

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 force-pushed the feature/587/compact-mode branch from 691863f to b20ea4d Compare August 29, 2018 15:35
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Really nice work @weeman1337 Thanks alot.

@juliusknorr juliusknorr merged commit 33764f6 into master Aug 29, 2018
@juliusknorr juliusknorr deleted the feature/587/compact-mode branch August 29, 2018 15:47
@Mannshoch
Copy link

Please insert the Color into the small view. Maybe as small line or a little Box without Text (as tool-tip)
grafik

@juliusknorr
Copy link
Member

Good point @Mannshoch mind to open an issue so we don't forget about this, since it is already merged?

@weeman1337
Copy link
Member Author

@Mannshoch with color you mean the tag colors, right?

@Mannshoch
Copy link

@weeman1337 yes

@Mannshoch
Copy link

If you asking because my comment on #15 (comment) that's why I set this colors in this Mockup in the lower center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants