Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choir(i18n): Change filter title #5957

Merged
merged 1 commit into from
Jun 7, 2024
Merged

choir(i18n): Change filter title #5957

merged 1 commit into from
Jun 7, 2024

Conversation

rakekniven
Copy link
Member

You do not filter for completed when selecting "filter for open".

Status is a better name for all existing options

You do not filter for completed when selecting "filter for open".

Status is a better name for all existing options

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@stefan-niedermann
Copy link
Member

Not sure, status might also refer to the corresponding list. Recently Completed has been replaced with Done, so maybe Filter for done state might be more close? Granted, one would need to check whether the length causes visual issues...

@rakekniven
Copy link
Member Author

rakekniven commented Jun 1, 2024

Bildschirmfoto 2024-06-01 um 18 25 53

IMHO "Filter by completed" and "open" do not fit together, they are contradictory from my POV.

@juliusknorr juliusknorr merged commit 0d52bd5 into main Jun 7, 2024
27 checks passed
@juliusknorr juliusknorr deleted the rakekniven-patch-1 branch June 7, 2024 12:38
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants