"assign to me" feature #544
Conversation
js/controller/BoardController.js
Outdated
| @@ -200,6 +200,27 @@ app.controller('BoardController', function ($rootScope, $scope, $stateParams, St | |||
| CardService.archive(card); | |||
| StackService.removeCard(card); | |||
| }; | |||
| $scope.isCurrentUserAssigned = function (card) { | |||
There was a problem hiding this comment.
Please use tabs instead of spaces.
There was a problem hiding this comment.
fixed by 02c1807f622e81212a97843779a90ed9641e9a7c
l10n/fr.js
Outdated
| @@ -96,6 +96,8 @@ OC.L10N.register( | |||
| "Shared boards" : "Tableaux partagés", | |||
| "View more" : "Voir plus", | |||
| "Move board to archive" : "Déplacer le tableau vers l'archive", | |||
| "Create a new board" : "Créer un nouveau tableau" | |||
| "Create a new board" : "Créer un nouveau tableau", | |||
There was a problem hiding this comment.
Please remove the changes to the translation files, those are added by transifex.
There was a problem hiding this comment.
fixed in 02926d93cb1864e16c4c6d628af4afdadb17bf5b
js/controller/BoardController.js
Outdated
| .then( | ||
| function() {StackService.updateCard(card);} | ||
| ); | ||
| $('.popovermenu').addClass('hidden'); |
There was a problem hiding this comment.
We should avoid using jquery in that way. Maybe you can have a look why the popovermenu is not closed in the directive that is opening it (see js/directive/appPopoverMenuUtils.js)
There was a problem hiding this comment.
Hi,
I don't manage to make it work with appPopoverMenuUtils.js.
I believe the click event is stopped by several stopPropagation at different levels.
I don't manage to make it work without entering deeply in the application code. I believe I don't have the necessary JS skills to make it work without breaking all the app :-)
Can you help me debug that point ?
Best regards,
Philippe
There was a problem hiding this comment.
Thanks for your pull request. I really like the idea. Can you have a look at the inline comments?
Please also make sure to add a sign-off message to your commits, as described here: https://github.com/nextcloud/deck#sign-your-work
codacy fix codacy fix #2 revert translation files coding style : spaces to tabs Signed-off-by: Philippe Le Van <philippe.levan@kibatic.com>
|
I squashed all the commits into a single one with my signed-off-by |
|
Hi @juliushaertl , I made the modifications I'm able to do right now. I'm blocked with your review on JQuery (see #544 (comment)). Best regards, |
Ok, I'd be fine to keep it like this for now, I can have a look into that afterwards. Mind to just add a TODO comment there? |
|
I just added the TODO comments |
|
Failing CI is fine, since it is about the missing signoff message on the merge commit and on a comment only commit. |
|
Thank you very much for your great contribution @philippe-levan If you are interested in getting involved further, be sure to checkout the list of good first issues. |
|
Thanks for your merge (and sorry for the signoff message, I'm not used to add that :-) ) Best regards and danke schön, |
Hi,
I suggest to add an "assign to me" feature on the contextual menu of each card.
Here is a PR.
Warnings :
Best regards,
Philippe
PS : here's a screnshot.
