allow user to toggle visibility of the calendar for a deck board #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiessle
force-pushed
the
allow-to-change-visibility
branch
from
0ddf568 to
ed6bef9
Compare
juliusknorr
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Makes sense in general, thanks a lot. However we'll need some additional permission check then for the places where we update the board details through the property changes: https://github.com/nextcloud/deck/blob/main/lib/DAV/Calendar.php#L187-L204
schiessle
force-pushed
the
allow-to-change-visibility
branch
from
ed6bef9 to
7ff29a9
Compare
The calendar object needs to be exposed with "write" properties in order to allow users to hide/show the corresponding calendar in the calendar app. It doesn't has any affects on the general permissions for the whole board or the tasks. As soon as you select a task you jump to the deck app where the normal deck permissions are applied. fixes: #4618 Signed-off-by: Björn Schießle <bjoern@nextcloud.com>
schiessle
force-pushed
the
allow-to-change-visibility
branch
from
7ff29a9 to
4804ca3
Compare
|
@juliushaertl I added the additional checks. |
Passing run #845 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
schiessle
force-pushed
the
allow-to-change-visibility
branch
from
4804ca3 to
330eaea
Compare
…e user doesn't has the "manage" permissions Signed-off-by: Bjoern Schiessle <bjoern@nextcloud.com>
juliusknorr
force-pushed
the
allow-to-change-visibility
branch
from
330eaea to
e2a4737
Compare
juliusknorr
approved these changes
Apr 27, 2023
|
Tested and works. I quickly fixed the php code style error. |
|
DCO check seems confused |
|
/backport to stable26 |
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Deck calendar always visible in calendar app #4618
Target version: main
Summary
The calendar object needs to be exposed with "write-properties" in order to allow users to hide/show the corresponding calendar in the calendar app. It doesn't has any affects on the general permissions for the whole board or the individual cards. As soon as you select a calendar item you jump to the deck app where the normal deck permissions are applied.
As far as I understand it, caldav knows two kind if write permissions:
Looking at how we treat shared regular calendars, I think the solution should be fine: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/Calendar.php#L181
TODO
Checklist
@juliushaertl This was a quick try to fix a issue I discovered, does it makes sense?