fix: Adapt NcEmptyContent usages to new slots #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
marcelklehr
reviewed
Mar 27, 2023
| @@ -71,12 +71,22 @@ | |||
| </div> | |||
| </div> | |||
| <div v-else id="modal-inner"> | |||
| <NcEmptyContent v-if="creating" icon="icon-loading"> | |||
| {{ t('deck', 'Creating the new card …') }} | |||
| <NcEmptyContent v-if="creating"> | |||
There was a problem hiding this comment.
Not sure if this counts as abuse but it certainly works :D
There was a problem hiding this comment.
😁 I'd argue the component name is just to limited
marcelklehr
approved these changes
Mar 27, 2023
|
/backport to stable26 |
|
/backport to stable25 |
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4523
Summary
NcEmptyContent has new slots that we should use to properly show the content
Checklist