Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rename functions accessibly by keyboard navigation #3813

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

juliushaertl
Copy link
Member

Fixes #3797

Screen.Recording.2022-05-12.at.13.48.45.mov

@cypress
Copy link

cypress bot commented May 12, 2022



Test summary

5 0 0 0


Run details

Project Deck
Status Passed
Commit a2cc425b58 ℹ️
Started Jul 5, 2022 9:23 PM
Ended Jul 5, 2022 9:24 PM
Duration 01:20 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!

@juliushaertl juliushaertl self-assigned this May 13, 2022
@juliushaertl juliushaertl force-pushed the bugfix/noid/rename-accessibility branch from 4f38f96 to ad5d68f Compare May 19, 2022 08:38
@juliushaertl juliushaertl force-pushed the bugfix/noid/rename-accessibility branch from ad5d68f to 3ae162b Compare May 19, 2022 11:59
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/rename-accessibility branch from 3ae162b to b3f252e Compare July 5, 2022 20:48
@juliushaertl
Copy link
Member Author

juliushaertl commented Jul 12, 2022

@vinicius73 @luka-nextcloud Re-reviews would be highly appreciated :)

@juliushaertl juliushaertl merged commit 0af348f into master Jul 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/rename-accessibility branch July 16, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot rename card with keyboard navigation
4 participants