Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text selection in dark mode and modal view #3761

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Fix text selection in dark mode and modal view #3761

merged 1 commit into from
Apr 29, 2022

Conversation

juliushaertl
Copy link
Member

Summary

  • Ensure that text in the modal is selectable (as it is blocked by the modal components touch handling)
  • Fix selection background color in dark mode

@juliushaertl juliushaertl added this to the Nextcloud 25 milestone Apr 28, 2022
@juliushaertl
Copy link
Member Author

/backport to stable24

@juliushaertl
Copy link
Member Author

/backport to stable23

@juliushaertl
Copy link
Member Author

/backport to stable22

luka-nextcloud
luka-nextcloud reviewed Apr 29, 2022
View reviewed changes
src/components/card/CardSidebar.vue
@@ -225,6 +225,9 @@ export default {
max-width: calc(100% - #{$modal-padding*2});
padding: 0 14px;
max-height: 100%;
user-select: text;
-webkit-user-select: text;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the support for other browsers?

-moz-user-select: text;
-webkit-user-select: text;
-ms-user-select: text;
user-select: text;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All recent major browsers should be fine without the prefix except for safari, according to https://caniuse.com/mdn-css_properties_user-select ;)

@juliushaertl
Fix text selection in dark mode and modal view
c089192 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 65d9a75 into master Apr 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3711 branch April 29, 2022 09:32
This was referenced Apr 29, 2022
Merged
Merged
Merged
@juliushaertl juliushaertl mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

@vinicius73 vinicius73 Awaiting requested review from vinicius73

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
1.8.0 (Nextcloud 25)
Development

Successfully merging this pull request may close these issues.

Selected text in description is not visible/readable
2 participants
@juliushaertl @luka-nextcloud