Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording to represent the code behavior #3685

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix wording to represent the code behavior #3685

merged 1 commit into from
Apr 8, 2022

Conversation

q-wertz
Copy link
Contributor

@q-wertz q-wertz commented Apr 1, 2022

Signed-off-by: Clemens Sonnleitner clemens.sonnleitner@web.de

Summary

Changed the wording to represent the code behavior (in this column the cards which are due in the next 7 days are shown not the one till end of week)

TODO

  • Run Test & check in browser (sorry don't have a test instance)
  • Translate string in Transifex

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Clemens Sonnleitner <clemens.sonnleitner@web.de>
@q-wertz
Copy link
Contributor Author

q-wertz commented Apr 1, 2022

I left the code the way it is and just changed the wording. Now wording and behavior is in line with the Deck app. Things like #2349 need more rework do be done.

@juliushaertl
Copy link
Member

Thanks for your pull request, that definitely makes sense to rename accordingly.

@juliushaertl juliushaertl merged commit c6dac7c into nextcloud:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wording in Upcoming cards view
2 participants