Increase file count after sharing #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
reviewed
Apr 5, 2022
|
@luka-nextcloud Could you check on the review comment so we can get that in? |
luka-nextcloud
force-pushed
the
bug/increase-file-count-after-sharing
branch
from
09c4076
to
65fab23
Compare
|
@juliushaertl Do we need to add a test for it now? |
|
If existing tests pass that should be fine for the backend side I'd say with the integration tests in https://github.com/nextcloud/deck/blob/master/tests/integration/features/sharing.feature For the frontend I've started collecting the case in #3768 so we can add it after the cypress parts are merged. |
|
Seems tests are not happy yet unfortunately ;) |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com> fix: conflicts Signed-off-by: Luka Trovic <luka@nextcloud.com> fix: conflicts and test issues Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliushaertl
force-pushed
the
bug/increase-file-count-after-sharing
branch
3 times, most recently
from
cc4badc
to
c11b027
Compare
juliushaertl
approved these changes
May 6, 2022
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bug/increase-file-count-after-sharing
branch
from
c11b027
to
03f4006
Compare
delete-merged-branch
bot
deleted the
bug/increase-file-count-after-sharing
branch
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
File count does not increase after sharing.
Checklist