🚸 Shows error on board fetchData #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
Mar 21, 2022
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
juliusknorr
force-pushed
the
feature/show-error-on-boad-fetchdata
branch
from
c08dc1a to
2e94b8e
Compare
delete-merged-branch
bot
deleted the
feature/show-error-on-boad-fetchdata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Target version: master
Summary
In some cases
fetchDatareceive errors from API, never stop the loading and no message appears to the user.This small change allows showing the API error to the user.
Checklist