Fix: Check all circle shares for permissions #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and good catch on the bug. Could you have a look at the failing DCO check? https://github.com/nextcloud/deck/pull/3625/checks?check_run_id=5639445346 should give you more details about that. Otherwise that is good to get merged from my side 👍 |
juliusknorr
approved these changes
Apr 11, 2022
|
Let's get this in without the DCO since it is a very minor change code wise. |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug that appears when a board is shared with multiple circles, causing calendars not to work because of a permission exception.
If a board is shared with a circle, the \OCA\Deck\Service\PermissionService::userCan method would only return the permissions for the first circle and not evaluate other permissions like groups or other circles. This is fixed by only returning true if the permissions are actually present and continuing the check when they are not.
TODO
Checklist